I value my ability to analyze people including myself and my friends, and including seeing things I don't particularly like or think healthy. I also often find it worth pointing out the things I see to a friend in question.
I don't find pointing things out that they are already aware of to be of any value, other than if I think that they will appreciate the reminder in some way. Which is not to say that I don't sometimes do this, but I at least try not to, and I try to curb the behavior when someone points out to me that I'm doing it ;)
With friendships, I consider it important to see what's there, and to be sure that the person and I are compatible, but upon establishing that, I consider it important to accept them, including what I may perceive as flaws. While its always great to strive to be the best one can be and to help one's friends achieve the same, people have to want to change in order to do so, and harping on them generally doesn't provide motivation ;)
While we will hopefully all evolve in positive ways, even by the end of life, we will probably all still have significant imperfections ;) To me, friendship is about people enjoying each other. It can be easy to lose sight of this in hopes of "improving" people so as to enjoy them more.
But often people don't want to change or can't for various reasons. And in trying to force change on them, the beauty of what is there, the reason the friendship was started in the first place, can be lost.
And if the change is vital for a friendship to endure, while
perhaps worth some effort to try, it is often best to let go of the
other person rather than try to force one's will upon them. To
appreciate what it is that was being fought for, while accepting that
it does not come in a package that works well with one's own.